-
Notifications
You must be signed in to change notification settings - Fork 217
Make hint about cloning example repo more prominent #6588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Arguably "CLICK HERE" in caps is not the nicest thing, but I didn't have an idea how to improve it otherwise. |
f17b076
to
f7cf51b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6588 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 399 399
Lines 40717 40717
=======================================
Hits 40358 40358
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I had the same though. Considering we can render an |
f7cf51b
to
44bcce5
Compare
A button, excellent! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand the current message. Why is it necessary to click any button to clone a distribution when openQA should clone the test distribution automatically on start? Under which circumstances do we get here?
Maybe "example distribution" could now be a link to GitHub. This way users who want to know more before hitting the "Clone" button could have a look beforehand. Otherwise it is actually still quite unclear what exactly will be cloned. @okurz I think your questions lead to far for a PR that is merely attempting to improve the UI (and not the logic behind). So I wouldn't block the merging of this PR on this discussion.
On the start of what? I don't think it is desirable that any openQA deployment automatically/unasked clones some additional repository from GitHub on first launch (if you mean that). We could trigger this automatically when one enters the specific page, though. I personally find it better if the cloning is triggered semi-automatic so users can follow better what's going on and the context of a potential error showing up is clearer.
By clicking on "Create … Example tests" on a freshly installed openQA instance where our example distribution hasn't been cloned yet. It is required to load the scenario definitions from there. |
I see. The document is expanded. How about a button inside the scenario definitions text edit field to load the file (not the complete repo) remotely on demand? Like "Click here to fetch example scenario definitions" |
44bcce5
to
26a6a7c
Compare
I now changed the text to be more informative. |
Related issue: https://progress.opensuse.org/issues/184459 I tried to create an example test in the webui, but the existing hint did not make clear to me that it would do something, I just thought it would be a link to the example distribution repo.
26a6a7c
to
f016c7b
Compare
Related issue: https://progress.opensuse.org/issues/184459
I tried to create an example test in the webui, but the existing hint did not make clear to me that it would do something, I just thought it would be a link to the example distribution repo.